SWED-2230 topbar transparent #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- logos smaller - scrollbar links container - logout btn anchored at bottom in modal - white gradient over links in nav modal - smaller btn size
- hack around scroll link-container in modal - font sizes links - paddings in modal - topbar height - transparency backdropopacity
- add support legacy topbar - refactor style new-topbar
This reverts commit 4921af2.
goldenraphti
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #905 +/- ##
===========================================
- Coverage 72.60% 72.31% -0.29%
===========================================
Files 212 212
Lines 4508 4573 +65
Branches 1263 1302 +39
===========================================
+ Hits 3273 3307 +34
- Misses 1097 1122 +25
- Partials 138 144 +6
Continue to review full report in Codecov by Sentry.
|
|
Size Change: +13.6 kB (+1%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
stepandersen
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New experimental Topbar
This PR is pretty big. Not in number of files, but it goes in various directions. Prepare yourself a coffee and hop on for the ride 😜
Description
Add a new Topbar. Still at an experimental phase. Therfore user need to actively opt-in to trigger it.
At this stage, if users do nothing they remain on the current topbar with no breaking change.
The new topbar does nevertheless includes breaking changes.
For this reason a new page for its migration to v2 is added to the documentations > components
Figma prototypes
Jira SWED-2230
Jira ticket: https://payexjira.atlassian.net/browse/SWED-2230
Feature branch: https://design.stage.swedbankpay.com/feature/SWED-2230-topbar_transparent/
Motivation and Context
How Has This Been Tested?
So far no new tests are added to test the new topbar. But all old tests made for the current topbar are (and must) successful.
Screenshots (if appropriate):
Types of changes
Checklist:
Review instructions
Review instructions